-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[default] Lack of modal backdrop #2319
Comments
Tip - there is an action for showing overlay in ui module |
I'm sorry to tell 😬 that the fix provided seems to "work" only when not logged in but when user are logged in, the submenu links all break by opening the login modal and consequently breaking the toggle of overlay and closing of sidebar. This problem rise up because of this behavior:
We should find a place, possibly the right one, where checking if a modal is triggered and a overlay is already shown, to not hide it. This should prevent any other similar bug. |
@pkarw I actually have developed a different solution during the hackathon, which I didn't push since is not very clean in my opinion (and there was also the other solution pending); I will when I get back at the pc so you guys can check if it's valid |
Perfect :) Thank You @francescosalvi |
Current behavior
Lack of modal backdrop entering "My account" from sidebar menu
Expected behavior
Modal backdrop should be visible
Steps to reproduce the issue
Visit: https://demo.storefrontcloud.io as a guest
Click on the menu
Click "My account"
Additional information
Should be:
The text was updated successfully, but these errors were encountered: