Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for checkout-do-placeOrder event - to make sure it's called only once no matter how many events are emited #2409

Closed
pkarw opened this issue Feb 10, 2019 · 0 comments
Closed

Add check for checkout-do-placeOrder event - to make sure it's called only once no matter how many events are emited #2409

pkarw opened this issue Feb 10, 2019 · 0 comments
Assignees
@patzick
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P0: Critical Priority mark - highest one
Milestone
1.8.3

Comments

@pkarw
Copy link
Collaborator

pkarw commented Feb 10, 2019

What is the motivation for adding / enhancing this feature?

It's related to #2407. Currently, there is a high chance that by minor issue module developer can fire the placeOrder few times which can cause critical issues.

We should hash the orders (objHash) and make sure one order is transmitted just once to the server in the placeOrder method to make it completely safe
@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Feb 10, 2019
@pkarw pkarw mentioned this issue Feb 26, 2019
Merged
2 tasks
@patzick patzick added the P0: Critical Priority mark - highest one label Feb 26, 2019
@patzick patzick added this to the 1.8.3 milestone Feb 26, 2019
@patzick patzick mentioned this issue Feb 26, 2019
Merged
5 tasks
@patzick patzick self-assigned this Feb 26, 2019
patzick added a commit to patzick/vue-storefront that referenced this issue Feb 26, 2019
@patzick
Merge branch 'develop' into bugfix/vuestorefront#2409-check-for-multi…
f47057a 
…ple-order-placing
patzick added a commit that referenced this issue Feb 26, 2019
@patzick
Merge pull request #2507 from patzick/bugfix/#2409-check-for-multiple…
4172027 
…-order-placing

Bugfix/#2409 check for multiple order placing
@patzick patzick closed this as completed Feb 26, 2019
@patzick patzick mentioned this issue Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patzick patzick

Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P0: Critical Priority mark - highest one
Projects
None yet
Milestone
1.8.3
Development

No branches or pull requests
2 participants
@pkarw @patzick