Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load more in Search Results not working #2659

Closed
revlis-x opened this issue Mar 27, 2019 · 1 comment
Closed

Load more in Search Results not working #2659

revlis-x opened this issue Mar 27, 2019 · 1 comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone
1.10.0-rc.1

Comments

@revlis-x
Copy link

revlis-x commented Mar 27, 2019 •
edited
Loading

Current behavior

When there are more search results then the initial batch a "Load more"-button is displayed, but clicking it does nothing. Seems vue-storefront-api response is not returning more products.

// EDIT: Problem only occurs, if you type the search term really fast (which triggers a lot of requests in short time). Request for more products then somehow has the wrong offset (e.g. from=36 instead of 18).

Expected behavior

Load more products and append them to the list.

Steps to reproduce the issue

  1. Go to https://demo.storefrontcloud.io
  2. Search for 'Shorts' (type fast)
  3. Click 'Load more' button

Can you handle fixing this bug by yourself?

NO

Which Release Cycle state this refers to? Info for developer.

https://demo.storefrontcloud.io
https://test.storefrontcloud.io
https://next.storefrontcloud.io
@revlis-x revlis-x added the bug Bug reports label Mar 27, 2019
@pkarw pkarw added 3: Medium complexity P3: Normal Priority mark - normal priority vs-hackathon Tasks for the Hackathon labels Mar 30, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Apr 16, 2019
@Flyingmana Flyingmana mentioned this issue May 24, 2019
Merged
7 tasks
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@patzick
Copy link
Collaborator

patzick commented May 27, 2019

Thanks @Flyingmana!

@patzick patzick closed this as completed May 27, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.10.0-rc.1
Development

No branches or pull requests
4 participants
@pkarw @revlis-x @patzick @alinadivante