Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect working of checkboxes in checkout #2730

Closed
2 of 4 tasks
GabiDivante opened this issue Apr 15, 2019 · 18 comments
Closed
2 of 4 tasks

Incorrect working of checkboxes in checkout #2730

GabiDivante opened this issue Apr 15, 2019 · 18 comments
Assignees
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@GabiDivante
Copy link
Collaborator

Current behavior

After marking the "ship to my default address" or "copy address data from shipping" checkbox, the form is not filled in with data, whereas after unmarking checkboxes - forms are filled in.
incorrectoperationofcheckboxe

Expected behavior

After selecting the "ship to my default address" or "copy address data from shipping" checkbox, the appropriate form is filled with data.

Steps to reproduce the issue

  1. Go to https://test.storefrontcloud.io
  2. Add any product to the cart
  3. Go to checkout
  4. Login to your account (which has memorized shipping details)
  5. Continue to shipping
  6. Mark checkbox "ship to my default address"
  7. Unmark checkbox "ship to my default address"
  8. Continue to payment
  9. Mark chceckbox "copy address data from shipping"
  10. Unmark checkbox "copy address data from shipping"

Can you handle fixing this bug by yourself?

  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome 73
  • OS: Windows 10

Additional information

This problem only appears on the environment https://test.storefrontcloud.io, does not appear on next and demo.

@GabiDivante GabiDivante added the bug Bug reports label Apr 15, 2019
@pkarw pkarw added 1: Easy P1: Urgent Priority mark - high priority labels Apr 15, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Apr 16, 2019
lukeromanowicz added a commit to lukeromanowicz/vue-storefront that referenced this issue Apr 16, 2019
pkarw added a commit that referenced this issue Apr 16, 2019
…ess-to-shipping

Fix handling same address checkbox in checkout - closes #2730
@pkarw pkarw closed this as completed Apr 16, 2019
@GabiDivante GabiDivante added the QA approved on branch Testers will add this label after positive check on specific branch. label Apr 23, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 27, 2019

@GabiDivante and @lukeromanowicz I still have this issue with the second checkobx "Ship to my default address"

Screenshot 2019-04-27 19 16 55

Please do re-check it and re-check all the checboxes in the app as it seems like a global issue with this component
This issue doesn't apply to 1.9.0

@pkarw pkarw reopened this Apr 27, 2019
@GabiDivante
Copy link
Collaborator Author

@pkarw @lukeromanowicz previously, I checked it on the branch and it was ok, now I checked it on develop

  1. "Shipping to my default address" does not work correctly.

I also checked all other checkboxes, the problem with the action appears for:

  1. My account -> My newsletter - after selecting the checkbox and saving the changes, then switching to another subpage and returning - the changes are not saved.
  2. Payment section in checkout (for logged in user with filled company data in My Profile) - the second checkbox appears "Use my billing data" - switching between checkboxes and selecting "I want to generate an invoice" do not work properly.

Peek 2019-04-29 10-39

@GabiDivante GabiDivante removed the QA approved on branch Testers will add this label after positive check on specific branch. label May 10, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 12, 2019

Hi @dimasch how about this issue? :)

@dimasch
Copy link
Collaborator

dimasch commented May 18, 2019

@pkarw In progress just now. ;)

@dimasch dimasch mentioned this issue May 18, 2019
8 tasks
@dimasch
Copy link
Collaborator

dimasch commented May 18, 2019

@pkarw PR is ready.

@pkarw
Copy link
Collaborator

pkarw commented May 21, 2019

Thanks Dima

@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 21, 2019
@pkarw pkarw closed this as completed May 22, 2019
@alinadivante
Copy link
Collaborator

@dimasch we need to improve this, because now, if I mark "Copy address data from shipping" it is correctly filled, but if i change my mind and I want to choose "Use my billing data", then form is cleared. I have to unmark selected checkbox and mark it again.

payment

@alinadivante alinadivante reopened this May 27, 2019
@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@patzick
Copy link
Collaborator

patzick commented May 27, 2019

I've merged this now, so it will be available for tests:)

@patzick patzick closed this as completed May 27, 2019
@alinadivante
Copy link
Collaborator

@dimasch @patzick unfortunately switching between above options (copy address data from shipping and use my billing data) still doesn't work correctly (form is cleared or address is not changed)

@alinadivante alinadivante reopened this May 28, 2019
@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 28, 2019
@dimasch
Copy link
Collaborator

dimasch commented Jun 5, 2019

@alinadivante Thanks. I will go to fix.

@pkarw
Copy link
Collaborator

pkarw commented Jun 8, 2019

@dimasch how about the status? :)

@dimasch
Copy link
Collaborator

dimasch commented Jun 8, 2019

@pkarw In progress. Actualize develop branch and today i will fix it.

@dimasch
Copy link
Collaborator

dimasch commented Jun 8, 2019

@pkarw I remember about the release 1.10rc1, and I will try to fix it over the weekend. ;)

@dimasch
Copy link
Collaborator

dimasch commented Jun 8, 2019

Ready. @pkarw
I attached the video how it works after the fix.

@alinadivante
Copy link
Collaborator

@dimasch I found one bug on your branch. Please see my video (it is about validation of Company name field)
invoice

@dimasch
Copy link
Collaborator

dimasch commented Jun 10, 2019

Ok, thanks, i will fix today evening.

@dimasch
Copy link
Collaborator

dimasch commented Jun 10, 2019

@alinadivante Fixed. Pls, try to check.

@alinadivante
Copy link
Collaborator

@dimasch yeah, now it works :)

@alinadivante alinadivante added the QA approved on branch Testers will add this label after positive check on specific branch. label Jun 11, 2019
@pkarw pkarw closed this as completed Jun 11, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 11, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

6 participants