-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect working of checkboxes in checkout #2730
Comments
…ess-to-shipping Fix handling same address checkbox in checkout - closes #2730
@GabiDivante and @lukeromanowicz I still have this issue with the second checkobx "Ship to my default address" Please do re-check it and re-check all the checboxes in the app as it seems like a global issue with this component |
@pkarw @lukeromanowicz previously, I checked it on the branch and it was ok, now I checked it on develop
I also checked all other checkboxes, the problem with the action appears for:
|
Hi @dimasch how about this issue? :) |
@pkarw In progress just now. ;) |
@pkarw PR is ready. |
Thanks Dima |
@dimasch we need to improve this, because now, if I mark "Copy address data from shipping" it is correctly filled, but if i change my mind and I want to choose "Use my billing data", then form is cleared. I have to unmark selected checkbox and mark it again. |
I've merged this now, so it will be available for tests:) |
@alinadivante Thanks. I will go to fix. |
@dimasch how about the status? :) |
@pkarw In progress. Actualize develop branch and today i will fix it. |
@pkarw I remember about the release 1.10rc1, and I will try to fix it over the weekend. ;) |
Ready. @pkarw |
@dimasch I found one bug on your branch. Please see my video (it is about validation of Company name field) |
Ok, thanks, i will fix today evening. |
@alinadivante Fixed. Pls, try to check. |
@dimasch yeah, now it works :) |
Current behavior
After marking the "ship to my default address" or "copy address data from shipping" checkbox, the form is not filled in with data, whereas after unmarking checkboxes - forms are filled in.
![incorrectoperationofcheckboxe](https://user-images.githubusercontent.com/49188852/56117548-9aceea80-5f68-11e9-9639-aa3e85edad2f.gif)
Expected behavior
After selecting the "ship to my default address" or "copy address data from shipping" checkbox, the appropriate form is filled with data.
Steps to reproduce the issue
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Environment details
Additional information
This problem only appears on the environment https://test.storefrontcloud.io, does not appear on next and demo.
The text was updated successfully, but these errors were encountered: