Fix handling same address checkbox in checkout - closes vuestorefront…

…#2730
lukeromanowicz · Apr 16, 2019 · 01023fc · 01023fc
1 parent 1272e64
commit 01023fc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/core/modules/checkout/components/Payment.ts b/core/modules/checkout/components/Payment.ts
@@ -1,7 +1,7 @@
 import { mapState, mapGetters } from 'vuex'
 import RootState from '@vue-storefront/core/types/RootState'
-const Countries = require('@vue-storefront/i18n/resource/countries.json')
 import toString from 'lodash-es/toString'
+const Countries = require('@vue-storefront/i18n/resource/countries.json')
 
 export const Payment = {
   name: 'Payment',
@@ -37,7 +37,7 @@ export const Payment = {
     }
   },
   mounted () {
-    if (!!this.payment.firstName) {
+    if (this.payment.firstName) {
       this.initializeBillingAddress()
     } else {
       if (this.payment.company) {
@@ -46,14 +46,19 @@ export const Payment = {
     }
     this.changePaymentMethod()
   },
-  watch:{
-    shippingDetails:{
+  watch: {
+    shippingDetails: {
       handler () {
         if (this.sendToShippingAddress) {
-          this.copyShippingToBillingAddress();
+          this.copyShippingToBillingAddress()
         }
       },
       deep: true
+    },
+    sendToShippingAddress: {
+      handler () {
+        this.useShippingAddress()
+      }
     }
   },
   methods: {
@@ -123,15 +128,15 @@ export const Payment = {
     },
     useShippingAddress () {
       if (this.sendToShippingAddress) {
-        this.copyShippingToBillingAddress();
+        this.copyShippingToBillingAddress()
         this.sendToBillingAddress = false
         this.generateInvoice = false
       } else {
         this.payment = this.$store.state.checkout.paymentDetails
         this.generateInvoice = false
       }
     },
-    copyShippingToBillingAddress(){
+    copyShippingToBillingAddress () {
       this.payment = {
         firstName: this.shippingDetails.firstName,
         lastName: this.shippingDetails.lastName,

diff --git a/src/themes/default/components/core/blocks/Checkout/Payment.vue b/src/themes/default/components/core/blocks/Checkout/Payment.vue
@@ -37,7 +37,6 @@
             class="col-xs-12 mb15"
             id="sendToShippingAddressCheckbox"
             v-model="sendToShippingAddress"
-            @click="useShippingAddress"
             v-if="!isVirtualCart"
           >
             {{ $t('Copy address data from shipping') }}