Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define optional attributes #2792

Closed
1 task
janmyszkier opened this issue Apr 25, 2019 · 4 comments
Closed
1 task

Define optional attributes #2792

janmyszkier opened this issue Apr 25, 2019 · 4 comments
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon

Comments

@janmyszkier
Copy link
Contributor

This originally requested with a bigger scope in #2231 but one of the tasks can still be done.

  • Would be great if the end the Product.ts type got updated marking the ? TypeScript notation - not required fields - where suitable.
@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 1: Easy vs-hackathon Tasks for the Hackathon good first issue Tasks that requires just basic understanding of Vue Storefront labels Apr 25, 2019
@ZeevGerstner
Copy link
Contributor

Can you tell whats the required fields so I can update the file?

@janmyszkier
Copy link
Contributor Author

@ZeevGerstner I think you can use boilerplate products/index element for that:
https://github.com/DivanteLtd/vue-storefront-integration-boilerplate/blob/master/1.%20Expose%20the%20API%20endpoints%20required%20by%20VS/Required%20API%20specification.md#get-vsbridgeproductsindex
I recently updated it by removing attributes never mentioned in the code.
So: if anything is not in the boilperplate products/index it's definitely an optional argument.

ZeevGerstner added a commit to ZeevGerstner/vue-storefront that referenced this issue May 2, 2019
pkarw added a commit that referenced this issue May 2, 2019
@basvanpoppel
Copy link
Contributor

@pkarw @janmyszkier i believe this issue can be closed, as the related PR is already merged to development branch.

@pkarw pkarw closed this as completed Jun 6, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants