Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Size Guide feature to prevent loosing product options selected by user #2913

Closed
2 of 6 tasks
pmaojo opened this issue May 16, 2019 · 1 comment
Closed
2 of 6 tasks
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@pmaojo
Copy link
Contributor

pmaojo commented May 16, 2019

What is the motivation for adding / enhancing this feature?

In a product page, If a user selects options( color and size for example) and clicks on "size guide" link:

  • the link to guide is opened on the same window.
  • A sidebar with links is shown atf. In mobile view that sidebar would have to go down, not before content.
  • no go back to product button
  • if I click back on browser, I see my choices have gone so I have to choose again

What are the acceptance criteria

  • user can see size guide without loosing product view and options selected

I think of two alternatives to solve this:

  • add target="_blank" to link
  • open size guide as a sideslider or popup

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@pmaojo pmaojo added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label May 16, 2019
@RGijsberts
Copy link
Contributor

I will work on this

RGijsberts added a commit to RGijsberts/vue-storefront that referenced this issue Jun 6, 2019
@patzick patzick added this to the 1.10.0-rc.1 milestone Jun 6, 2019
RGijsberts added a commit to RGijsberts/vue-storefront that referenced this issue Jun 6, 2019
RGijsberts added a commit to RGijsberts/vue-storefront that referenced this issue Jun 6, 2019
RGijsberts added a commit to RGijsberts/vue-storefront that referenced this issue Jun 6, 2019
@pkarw pkarw closed this as completed Jun 11, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 11, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

5 participants