Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Size Guide feature to prevent loosing product options selected by user #3029

Merged

Conversation

RGijsberts
Copy link
Contributor

@RGijsberts RGijsberts commented Jun 6, 2019

Related issues

closes #2913

Short description and why it's useful

Instead of directing the user to a new page that contains the size guide information, it now triggers a modal popup with that information.
It is useful because the user won't leave the page and won't loose his choices (product color, size, amount etc.)

Screenshots of visual changes before/after (if there are any)

Screenshot 2019-06-06 at 14 36 58

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@filrak filrak self-requested a review June 7, 2019 05:44
@patzick patzick added the vs-hackathon Tasks for the Hackathon label Jun 7, 2019
@pkarw pkarw merged commit 2f0a421 into vuestorefront:develop Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants