Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ratio of photo #3187

Closed
2 of 5 tasks
alinadivante opened this issue Jul 5, 2019 · 0 comments
Closed
2 of 5 tasks

Change ratio of photo #3187

alinadivante opened this issue Jul 5, 2019 · 0 comments
Assignees
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can M: takes some effort Smaller new feature of rewrite of existing code, takes multiple hours
Milestone

Comments

@alinadivante
Copy link
Collaborator

What is the motivation for adding / enhancing this feature?

Some of photos have improperly ratio.
Please compare demo https://demo.storefrontcloud.io/gear/gear-3/sprite-yoga-companion-kit-45.html to test environment https://test.storefrontcloud.io/gear/gear-3/sprite-yoga-companion-kit-45.html
image
image

What are the acceptance criteria

Please fix aspect ratio

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@alinadivante alinadivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Jul 5, 2019
@pkarw pkarw added this to the 1.10.0 milestone Jul 5, 2019
@pkarw pkarw added the 1: Easy label Jul 5, 2019
@filrak filrak added the XS: Minimal effort One line of code or simple setting label Jul 6, 2019
@pspaczek pspaczek mentioned this issue Jul 11, 2019
15 tasks
patzick added a commit that referenced this issue Jul 12, 2019
@patzick patzick added M: takes some effort Smaller new feature of rewrite of existing code, takes multiple hours and removed XS: Minimal effort One line of code or simple setting labels Jul 12, 2019
@patzick patzick modified the milestones: 1.10.0, 1.11.0-rc.1 Jul 12, 2019
@patzick patzick closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can M: takes some effort Smaller new feature of rewrite of existing code, takes multiple hours
Projects
None yet
Development

No branches or pull requests

5 participants