Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#3187 #3219

Merged
merged 15 commits into from Jul 12, 2019
Merged

Bugfix/#3187 #3219

merged 15 commits into from Jul 12, 2019

Conversation

pspaczek
Copy link
Collaborator

Related issues

closes #3187

Short description and why it's useful

I expand ProdutImage component, now it:

  1. detect default images aspect ratio, base on config (default is true but you can disabled for example ProductTile
  2. detect widthnes or hightnes image and use right behavior for it
    With components used ProductImage?
  • ProductGalleryCarousel
  • ProductGalleryZoomCarousel
  • Microcart
  • ProductTile
  • Wishlist
  • Checkout
  • ProductGallery

Screenshots of visual changes before/after (if there are any)

localhost_3000_training_training-9_luma-yoga-for-life-51 html
localhost_3000_gear_gear-3_sprite-yoga-companion-kit-45 html
localhost_3000_training_training-9_luma-yoga-for-life-51 html (1)

localhost_3000_training_training-9_luma-yoga-for-life-51 html (2)
localhost_3000_training_training-9_luma-yoga-for-life-51 html (3)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pspaczek pspaczek added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jul 11, 2019
@pspaczek pspaczek added this to the 1.10.0 milestone Jul 11, 2019
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool :)

@alinadivante alinadivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jul 11, 2019
@pkarw pkarw requested a review from patzick July 11, 2019 19:21
@patzick patzick modified the milestones: 1.10.0, 1.11.0-rc.1 Jul 12, 2019
@patzick patzick merged commit 336c2ee into vuestorefront:develop Jul 12, 2019
@patzick
Copy link
Collaborator

patzick commented Jul 12, 2019

@przspa does this also close #3196?

@pspaczek
Copy link
Collaborator Author

pspaczek commented Jul 12, 2019

@patzick yes 👍 I close it

@pspaczek pspaczek deleted the bugfix/#3187 branch July 16, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants