Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way we're prerfetching i18n for dayjs + VS locale #3498

Closed
pkarw opened this issue Sep 5, 2019 · 1 comment
Closed

Fix the way we're prerfetching i18n for dayjs + VS locale #3498

pkarw opened this issue Sep 5, 2019 · 1 comment
Assignees
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented Sep 5, 2019

What is the motivation for adding / enhancing this feature?

Currently in the production mode we're prefetching all possible locales:
https://www.dropbox.com/s/jktt4j5123g9cc0/Screenshot%202019-09-05%2021.05.07.png?dl=0

We shouldn't. It's because:

are expanded by webpack (glob) to all possible locales - then prefetched

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Sep 5, 2019
@pkarw pkarw added this to the 1.10.2 milestone Sep 5, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Sep 5, 2019

This occurs only in production mode. Potential fix:
https://github.com/jantimon/resource-hints-webpack-plugin

plugins: [
  new HtmlWebpackPlugin({
    prefetch: ['**/*.*'],
    preload: ['**/*.*']
  }),
  new ResourceHintWebpackPlugin()
]  

@pkarw pkarw added 3: Medium complexity P2: Important Priority mark - still high ;) labels Sep 5, 2019
@pkarw pkarw modified the milestones: 1.10.2, 1.11.0 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Projects
None yet
Development

No branches or pull requests

3 participants