Fix - Adjusted search sidebar component #971 #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diboy2
force-pushed
the
fix/search-sidebar-widget-component-adjustment
branch
from
c3be68d
to
7e0cb99
Compare
filrak
requested changes
Oct 17, 2018
| } | ||
|
|
||
| .container { | ||
| padding-left: 40px; |
There was a problem hiding this comment.
it would be wiser to use atomic classes for paddings and margins just to save this few bits on css size ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#971
Short description and why it's useful
Modifies searchbar component.
Screenshots of visual changes before/after (if there are any)
before:
after:
(if you made any changes in the UI layer please provide before/after screenshots)
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
(run
yarn tests:e2eand paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)Upgrade Notes and Changelog
Contribution and curently important rules acceptance