Skip to content

Fix - Adjusted search sidebar component #971 #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Fix - Adjusted search sidebar component #971 #1862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 140 additions & 64 deletions src/themes/default/components/core/blocks/SearchPanel/SearchPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,50 +4,59 @@
:class="{ active: isOpen }"
data-testid="searchPanel"
>
<div class="row">
<div class="col-md-12 end-xs">
<i
class="material-icons p15 pointer cl-accent"
@click="closeSearchpanel"
data-testid="closeSearchPanel"
>
close
</i>
</div>
</div>
<div class="col-md-12 end-xs">
<label for="search" class="visually-hidden">
{{ $t('Search') }}
</label>
<input
ref="search"
id="search"
v-model="search"
@input="makeSearch"
class="mr20 py10 brdr-none brdr-bottom-1 brdr-cl-primary no-outline h4"
:placeholder="$t('Type what you are looking for...')"
type="text"
<div class="close-icon-row">
<i
class="material-icons pointer cl-accent close-icon"
@click="closeSearchpanel"
data-testid="closeSearchPanel"
>
close
</i>
</div>
<div class="col-md-12 product-listing pl35 pt20 row">
<product-tile @click.native="closeSearchpanel" :key="product.id" v-for="product in products" :product="product"/>
<transition name="fade">
<div v-if="emptyResults" class="no-results relative center-xs h4">
{{ $t('No results were found.') }}
<div class="container">
<div class="row">
<div class="col-md-12 end-xs">
<label for="search" class="visually-hidden">
{{ $t('Search') }}
</label>
<div class="search-input-group">
<i
class="material-icons search-icon"
>
search
</i>
<input
ref="search"
id="search"
v-model="search"
@input="makeSearch"
class="search-panel-input"
:placeholder="$t('Type what you are looking for...')"
type="text"
>
</div>
</div>
</transition>
</div>
<div v-show="OnlineOnly" v-if="products.length >= 18" class="buttons-set align-center py35 mt20 px40">
<button @click="seeMore" v-if="readMore"
class="no-outline brdr-none py15 px20 bg-cl-mine-shaft :bg-cl-th-secondary cl-white fs-medium-small"
type="button">
{{ $t('Load more') }}
</button>
<button @click="closeSearchpanel"
class="no-outline brdr-none p15 fs-medium-small close-button"
type="button">
{{ $t('Close') }}
</button>
</div>
<div class="product-listing row">
<product-tile @click.native="closeSearchpanel" :key="product.id" v-for="product in products" :product="product"/>
<transition name="fade">
<div v-if="emptyResults" class="no-results relative center-xs h4 col-md-12">
{{ $t('No results were found.') }}
</div>
</transition>
</div>
<div v-show="OnlineOnly" v-if="products.length >= 18" class="buttons-set align-center py35 mt20 px40">
<button @click="seeMore" v-if="readMore"
class="no-outline brdr-none py15 px20 bg-cl-mine-shaft :bg-cl-th-secondary cl-white fs-medium-small"
type="button">
{{ $t('Load more') }}
</button>
<button @click="closeSearchpanel"
class="no-outline brdr-none p15 fs-medium-small close-button"
type="button">
{{ $t('Close') }}
</button>
</div>
</div>
</div>
</template>
Expand Down Expand Up @@ -85,46 +94,113 @@ export default {
transition: transform 300ms $motion-main;
overflow-y: auto;
overflow-x: hidden;
.close-icon-row {
display: flex;
justify-content: flex-end;
}

.container {
padding-left: 40px;
Copy link
Collaborator

@filrak filrak Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be wiser to use atomic classes for paddings and margins just to save this few bits on css size ;)

Copy link
Author

@diboy2 diboy2 Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will dio.

padding-right: 40px;
}

.row {
margin-left: -15px;
margin-right: -15px;
}

.col-md-12 {
padding-left: 15px;
padding-right: 15px;
}

.product-listing {
padding-top: 30px;
}

.product {
box-sizing: border-box;
width: 33.33%;
padding-left: 15px;
padding-right: 15px;
}

&.active {
transform: translateX(0)
}

.product {
width: 30%;
padding: 10px;
.close-icon {
padding: 18px 8px;
}

input {
width: calc(100% - 40px);
.search-input-group {
display: flex;
border-bottom: 1px solid #bdbdbd;
}

.search-icon {
width: 60px;
height: 60px;
display: flex;
align-items: center;
justify-content: center;
}

.search-panel-input {
border: none;
width: 100%;
padding-bottom: 0px;
padding-top: 0px;
outline: 0;
height: 60px;
}

.no-results {
top: 80px;
width: calc(100% - 40px);
width: 100%;
}
}

i {
opacity: 0.6;
}
i {
opacity: 0.6;
}

i:hover {
opacity: 1;
}
i:hover {
opacity: 1;
}

.close-button {
background: #fff;
.close-button {
background: #fff;
}
}

@media only screen and (max-width:50em) {
.searchpanel .product {
width: 50%;
box-sizing: border-box;
}
button {
width: 100%;
margin-bottom: 15px;
@media only screen and (max-width:575.98px) {
.searchpanel {

.container {
padding-left: 30px;
padding-right: 30px;
}

.row {
margin-right: -10px;
margin-left: -10px;
}

.col-md-12 {
padding-left: 10px;
padding-right: 10px;
}

.product {
width: 50%;
padding-left: 10px;
padding-right: 10px;
}

button {
width: 100%;
margin-bottom: 15px;
}
}
}
</style>