Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event bus import removal #2630

Merged
merged 6 commits into from
Apr 1, 2019
Merged

Event bus import removal #2630

merged 6 commits into from
Apr 1, 2019

Conversation

szafran89
Copy link
Collaborator

IMO we can remove EventBus import and use $bus plugin

@patzick
Copy link
Collaborator

patzick commented Mar 22, 2019

@szafran89 there should be one consistent way of calling EventBus in components, your proposal is okay to me - would you consider changing all uses with this PR? :)

@filrak
Copy link
Collaborator

filrak commented Mar 23, 2019

Agree, can you check the other imports too?

@szafran89
Copy link
Collaborator Author

Yes, I'll check it tomorrow

@filrak
Copy link
Collaborator

filrak commented Mar 29, 2019

image

@szafran89
Copy link
Collaborator Author

Sorry for delay, I'll check it ASAP :D

@szafran89
Copy link
Collaborator Author

@patzick please check again, now should be ready to merge ;) There are a few more places with EventBus but can't change it b/c it is called before initiating the component.

@patzick patzick added this to the 1.10.0-rc.1 milestone Apr 1, 2019
@patzick patzick merged commit 8b3a1c5 into vuestorefront:develop Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szafran89 @patzick @filrak