-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event bus import removal #2630
Event bus import removal #2630
Conversation
@szafran89 there should be one consistent way of calling EventBus in components, your proposal is okay to me - would you consider changing all uses with this PR? :) |
Agree, can you check the other imports too? |
Yes, I'll check it tomorrow |
Sorry for delay, I'll check it ASAP :D |
@patzick please check again, now should be ready to merge ;) There are a few more places with |
IMO we can remove
EventBus
import and use$bus
plugin