Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2663 fix multiple orders per submit error #2751

Closed
wants to merge 1 commit into from
Closed

#2663 fix multiple orders per submit error #2751

wants to merge 1 commit into from

Conversation

AndreiBelokopytov
Copy link
Contributor

Related issues

closes #2663

Short description and why it's useful

It prevents repeating order requests by disabling order caching in case of sever error (over than 200 status). Also changed text of notification message.

Screenshots of visual changes before/after (if there are any)

https://yadi.sk/i/IX8Pw-alt2XI2Q

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented Apr 17, 2019

Please do test od the order is being queued in case of offline mode / no network connectivity.

Please do also check what’s happening with the directOrsers mode is off (so when by default order is being queued); in that case we should probably remove it from the queue in case of wrong HTTP status

Please remember to update the vs-api and to try checking the response codes because as you wrote in the issue: 500 error / like a database error /
Whatever is a different story than Magento2 api error (in this case 99% is a validation issue)

@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

@AndreiBelokopytov how about the proposed changes?

@AndreiBelokopytov
Copy link
Contributor Author

@AndreiBelokopytov how about the proposed changes?

Hi @pkarw. I will take a look at it one of these days

@lukeromanowicz lukeromanowicz changed the base branch from master to release/1.9 April 25, 2019 07:16
@lukeromanowicz
Copy link
Contributor

@AndreiBelokopytov if you don't mind I'll fix it myself because we really need it in 1.9 and I'd like to fix the old notification instead of introducing some new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants