-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/product image loader #2925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do check the usage of !!
operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, mostly things we've discussed.
After improvements QA team should checkout this branch and test images on category, homepage and product pages locally before we will merge that in (notice to @pkarw :) )
src/themes/default/components/core/ProductGalleryZoomCarousel.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/ProductGalleryZoomCarousel.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/ProductGalleryZoomCarousel.vue
Outdated
Show resolved
Hide resolved
I used https://css-tricks.com/aspect-ratio-boxes/ to maintaining image size. I used to this mathematic formula {height% / ( width / 100 )} |
Merged and ready for tests |
Related to #2863 - @przspa please take a look :) |
|
Short description and why it's useful
I extract to the new component images loading strategy implemented in Product Gallery Carousel and use it on Producta Gellery Carousel and Product Gallery Zoom Carousel components.
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance