Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No placeholders in gallery - offline mode #2863

Closed
2 of 5 tasks
ArturDivante opened this issue May 7, 2019 · 7 comments
Closed
2 of 5 tasks

No placeholders in gallery - offline mode #2863

ArturDivante opened this issue May 7, 2019 · 7 comments
Assignees
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Milestone

Comments

@ArturDivante
Copy link
Collaborator

ArturDivante commented May 7, 2019

Related issues

#2557

Current behavior

If given product was not opened before going offline, then gallery opened in offline mode will contain no pictures (except default one) or placeholders , just ugly missing-graphics-icon :)

noplaceholder2

Expected behavior

Pictures or placeholreds should be displayed instead.

Steps to reproduce the issue

  1. Open demo.storefrontcloud.io
  2. Open some cataegory pages and product pages
  3. Turn offline
  4. Navigate to page of product you didn't load before going offline
  5. Open picture gallery
  6. Switch to non-default photo

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Many - desktop and mobile
  • OS: Win10, android

Additional information

I given product page was loaded before going offline, pictures and thumbnails in gallery will be displayed correctly.

@ArturDivante ArturDivante added the bug Bug reports label May 7, 2019
@patzick patzick added this to the 1.10.0-rc.1 milestone May 7, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 7, 2019

This is not na issue - rather an improvement .
We should show other images in offline mode at all. There should be just one single picture without the gallery at all (as it was prior to 1.8)

@pkarw pkarw added 3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can and removed bug Bug reports labels May 7, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 9, 2019

We do have the same behavior with online mode / placeholder is not visible while picture is being loded

@pkarw
Copy link
Collaborator

pkarw commented May 9, 2019

We do have the same behavior with online mode / placeholder is not visible while picture is being loaded

@pkarw
Copy link
Collaborator

pkarw commented Jun 3, 2019

We should keep only one single picture in the offline mode without the Gallery component at all.

@patzick patzick assigned pspaczek and unassigned patzick Jun 3, 2019
@patzick
Copy link
Collaborator

patzick commented Jun 3, 2019

@przspa please take a look if your component is used here. Also in offline mode there should not be zoom option.

@pkarw pkarw closed this as completed Jun 8, 2019
pkarw added a commit that referenced this issue Jun 11, 2019
Bugfix/#2863 No placeholders in gallery - offline mode
pkarw added a commit that referenced this issue Jun 11, 2019
Revert "Bugfix/#2863 No placeholders in gallery - offline mode"
@benoitemile
Copy link

We should keep only one single picture in the offline mode without the Gallery component at all.

Hello, could you please explain why ?
In a flaky connection, (talking about being in transports with online/offline switching) when using site you're viewing gallery component with vue carousel slider and images; suddenly, you're offline and switched to a single image where client already downloaded images; then you come back online and get the carousel back again.
Isn't it confusing for the end user ?

Why not showing placeholder images for non-previously-loaded images ? keeping the experience the same ?

@pkarw
Copy link
Collaborator

pkarw commented Jan 17, 2020

It was done on purpose. If we don;'t have the images (offline mode) it makes a little sense for the user to show the gallery - it's pretty much frustrating to swipe off empty placeholders in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
None yet
Development

No branches or pull requests

5 participants