-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No placeholders in gallery - offline mode #2863
Comments
This is not na issue - rather an improvement . |
We do have the same behavior with online mode / placeholder is not visible while picture is being loded |
We do have the same behavior with online mode / placeholder is not visible while picture is being loaded |
We should keep only one single picture in the offline mode without the Gallery component at all. |
@przspa please take a look if your component is used here. Also in offline mode there should not be zoom option. |
Bugfix/#2863 No placeholders in gallery - offline mode
Revert "Bugfix/#2863 No placeholders in gallery - offline mode"
Hello, could you please explain why ? Why not showing placeholder images for non-previously-loaded images ? keeping the experience the same ? |
It was done on purpose. If we don;'t have the images (offline mode) it makes a little sense for the user to show the gallery - it's pretty much frustrating to swipe off empty placeholders in the end |
Related issues
#2557
Current behavior
If given product was not opened before going offline, then gallery opened in offline mode will contain no pictures (except default one) or placeholders , just ugly missing-graphics-icon :)
Expected behavior
Pictures or placeholreds should be displayed instead.
Steps to reproduce the issue
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Environment details
Additional information
I given product page was loaded before going offline, pictures and thumbnails in gallery will be displayed correctly.
The text was updated successfully, but these errors were encountered: