Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid increase of start property of Search when function runs in parallel #2946

Conversation

Flyingmana
Copy link
Contributor

@Flyingmana Flyingmana commented May 24, 2019

Related issues

closes #2659

Short description and why it's useful

the start value in the end should always depend on the start value, it
started with. Runs which happen in parallel do not affect the showed
products, so they should also not affect the start value

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

the start value in the end should always depend on the start value, it
started with. Runs which happen in parallel do not affect the showed
products, so they should also not affect the start value
@patzick patzick changed the base branch from develop to develop_merge_bulk May 27, 2019 11:50
@patzick patzick merged commit f6ea923 into vuestorefront:develop_merge_bulk May 27, 2019
@patzick patzick added the vs-hackathon Tasks for the Hackathon label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants