Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing a different UI #1

Merged
merged 28 commits into from
May 26, 2024
Merged

Testing a different UI #1

merged 28 commits into from
May 26, 2024

Conversation

DivergentEuropeans
Copy link
Owner

@DivergentEuropeans DivergentEuropeans commented Mar 17, 2024

So from:

image

to:

(see below comment)

For full discussion, go to:
https://gitlab.com/divergenteuropeans/loser-simulator/-/merge_requests/5

Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
…oser-simulator into updates

Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
@DivergentEuropeans
Copy link
Owner Author

DivergentEuropeans commented Apr 28, 2024

Most recent version! @Priyansh61 Should have addressed most of your comments!

Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
@DivergentEuropeans
Copy link
Owner Author

Updated tutorials:

image

image

image

@DivergentEuropeans
Copy link
Owner Author

  • different UI
  • added dialogue options
  • fixed tutorials

Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
@DivergentEuropeans
Copy link
Owner Author

new UI:

image

Copy link
Collaborator

@Priyansh61 Priyansh61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I dont know but the navbar buttons dont directly work, they redirect the user toward the left panel.

image

The color here of the text makes it impossible to read

image

The icon next to advice has very few contrast ratio...

image

Overlapping money with the status bars

  • The icon next to text problem is at many places since the icons are suited to light bgs but now due to darker colors they are really difficult to understand what are they meant for?

  • Yeah!!! the above problem is there at almost every place so we can either invert the color of all the dark icons

image

Should we present the user with 3 locked tiles or should we just have 1 locked tile everytime and that tile gets unlocked over the time you progress in the game, IG this UX would be much better.

@DivergentEuropeans
Copy link
Owner Author

I dont know but the navbar buttons dont directly work, they redirect the user toward the left panel.

This will be a mockup for now until we decide something better

The color here of the text makes it impossible to read

Ty! Fixed. Intrestingly can't replicate the other issue
image

The icon next to text problem is at many places since the icons are suited to light bgs but now due to darker colors they are really difficult to understand what are they meant for?

That's a very true point. Ok will fix

Yeah!!! the above problem is there at almost every place so we can either invert the color of all the dark icons

Wdym? If you're talking about the page title text, the black is the secondary color to the icon. I guess you're right it could be made different, but it's not primary

Should we present the user with 3 locked tiles or should we just have 1 locked tile everytime and that tile gets unlocked over the time you progress in the game, IG this UX would be much better.

Thanks, great Q. I want to intentionally leave some mystery to explore

Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
Signed-off-by: Leanid Astrakou <LeanyIA@yahoo.com>
@DivergentEuropeans
Copy link
Owner Author

Ok, check it out @Priyansh61

image

  • Better color for icons
  • Better padding for text fields, +fixed positioning and color for text
  • Better background

@Priyansh61
Copy link
Collaborator

@DivergentEuropeans LGTM :)

@DivergentEuropeans DivergentEuropeans merged commit 80849b8 into v2.x/master May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants