Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cypher functions to prevent throttling #4

Merged
merged 8 commits into from
Jun 13, 2022

Conversation

JasperVanEsveld
Copy link
Contributor

Updates sig.ts to use cypher functions instead (PR that added it to ytdl-core)
Only slight issue is that it requires to run external code (from google), Node.js can use vm
Which might be more secure compared to new Function() which I used here.

Also adds support for DashMPD and HLS using m3u8stream from esm.js

@JasperVanEsveld
Copy link
Contributor Author

@DjDeveloperr
Hey can you maybe look at this?
In my opinion this makes ytdl-core actually usable, before it would download but way too slow
I am using my fork at the moment, but other people who want to try this will be scared off by the slow downloads

I know it is quite a lot of changes, though mostly just taken from npm version of ytdl-core

@DjDeveloperr
Copy link
Owner

Hey, thanks for the contribution.
I'm sorry for not reviewing for so long. I will review it when I get home (in few hours).

Copy link
Owner

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DjDeveloperr DjDeveloperr merged commit cbdfa78 into DjDeveloperr:main Jun 13, 2022
@JasperVanEsveld
Copy link
Contributor Author

Nice 🎉
And no worries life gets in the way ;)

Could you also make a new release @DjDeveloperr?
Last one is 11 months old

@DjDeveloperr
Copy link
Owner

Sure, tagged 0.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants