Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark link as broken when anchor is not found #98

Closed
claudep opened this issue Mar 13, 2020 · 3 comments · Fixed by #124
Closed

Do not mark link as broken when anchor is not found #98

claudep opened this issue Mar 13, 2020 · 3 comments · Fixed by #124

Comments

@claudep
Copy link
Contributor

claudep commented Mar 13, 2020

In some cases, anchors are not found in the page html source but the anchor is still valid and functional. For example, a youtube video where the anchor is used to set the seek point in the video.

I would suggest to not mark those links as broken, but just add a message like "Page OK but anchor was not found in page source". What do you think?

@andybak
Copy link
Member

andybak commented Mar 13, 2020

Would it work to make it configurable? We use this on sites where we definitely want this behaviour and I can imagine other sites where we might not.

That's certainly less work than adding a new status but a new status might be a better long-term solution. However it would be good to make sure it permeated correctly through the system so it was always actionable if needed.

@claudep
Copy link
Contributor Author

claudep commented Mar 13, 2020

I'm not sure to understand your last sentence, could you please clarify?

@andybak
Copy link
Member

andybak commented Mar 13, 2020

I guess I was saying "I don't have linkcheck in front of me right now but any new status would have to be reflected in the right places in the UI so that it was actually useful"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants