Social Oauth需要的潜在后端代码 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 75
💛 - Coveralls |
ghost
reviewed
Apr 28, 2018
config/settings/common.py
Outdated
| @@ -180,6 +180,10 @@ | |||
| REST_AUTH_SERIALIZERS = { | |||
| 'USER_DETAILS_SERIALIZER': 'users.serializers.UserDetailsSerializer', | |||
| } | |||
| SOCIAL_LOGIN_GOOGLE_CALLBACK_URL = os.environ.get( | |||
There was a problem hiding this comment.
这里是google还是github?另外我记得要使用第三方登录是要将对应的provider加入app的？
There was a problem hiding this comment.
嗯是github，复制粘贴的错误，已经修正。provider已经加了的，你忘了我们现在已经可以用github登陆了么～这个只是配置REST的流程
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这部分代码量少且功能独立于现有产品之外，没有任何对现有API逻辑的更改，只是新增了一批将来可能会用到的rest-auth相关的终端，可以考虑合并到仓库以便有可能的前端用户模块逻辑更改和调试。