Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to EventApplication model #576

Merged
merged 13 commits into from May 10, 2021

Conversation

amakarudze
Copy link
Contributor

  • Add functionality to check if the organizer has an open application before submitting the application.
  • Add functionality to check if the organizer has had an event in the past 6 months before submitting the application.
  • Add tests to increase organize app coverage

@codecov-commenter
Copy link

Codecov Report

Merging #576 (0aec40a) into master (5620904) will increase coverage by 0.31%.
The diff coverage is 74.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   70.69%   71.00%   +0.31%     
==========================================
  Files          85       85              
  Lines        2692     2763      +71     
  Branches      267      274       +7     
==========================================
+ Hits         1903     1962      +59     
- Misses        725      738      +13     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
core/urls.py 100.00% <ø> (ø)
djangogirls/urls.py 88.88% <ø> (ø)
organize/admin.py 64.00% <0.00%> (-1.31%) ⬇️
organize/urls.py 100.00% <ø> (ø)
organize/views.py 70.21% <52.63%> (+21.72%) ⬆️
organize/models.py 85.36% <60.86%> (-5.82%) ⬇️
organize/forms.py 79.51% <92.85%> (+18.80%) ⬆️
core/validators.py 100.00% <100.00%> (+50.00%) ⬆️
djangogirls/settings.py 85.91% <100.00%> (ø)
sponsor/urls.py 0.00% <0.00%> (-100.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a2227...0aec40a. Read the comment docs.

Copy link
Contributor

@RachellCalhoun RachellCalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amakarudze amakarudze merged commit a20a449 into DjangoGirls:master May 10, 2021
@amakarudze amakarudze deleted the updates branch August 17, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants