New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 3.2 upgrade #667
Django 3.2 upgrade #667
Conversation
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 76.98% 77.28% +0.29%
==========================================
Files 88 88
Lines 2381 2390 +9
Branches 222 225 +3
==========================================
+ Hits 1833 1847 +14
+ Misses 496 490 -6
- Partials 52 53 +1
Continue to review full report at Codecov.
|
054ae04
to
de684ad
Compare
This has been rebased with the translations changes. |
6bce453
to
e34311e
Compare
…ike python-dotenv
fd265f5
to
5a52e41
Compare
Hey, @marksweb. Let me know when this is ready for review. I keep seeing more changes to this PR. Or maybe we can wait until the errors brought about by 2.2 are resolved before we can move ahead? |
Hello @amakarudze This was OK. Looks like coverage wasn't happy. Will see if I can rerun jobs. All I recently did here was rebase the latest main I think. |
Ah I can see I've ended up with a version of Django countries here that's unsupported. Got old python 2 support refs to six Will fix ASAP |
Ok @marksweb. Let me know when it's ready for review. Thanks |
@amakarudze ok checks passing again 👌👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good @marksweb. Thanks for all your work.
Just a question on the changed contact URL, why you thought of changing it - no need to change it back, by the way. Also maybe, it's high time we removed Opbeat settings in pytest.ini
. See my comments.
Had to revert this @marksweb. See Sentry for the issues. Thanks |
I did run the migrations locally and they worked. We had some unapplied migrations on the server and running |
@amakarudze Ok thanks. There's quite a lot on sentry to investigate. We really need a way to make python anymore more reliable. 😞 |
This follows on from the django 2.2 upgrade, this time bringing django to 3.2.