Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markup: don't treat Django template tags as GitBook tags #141

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

das-g
Copy link
Member

@das-g das-g commented Jan 25, 2021

Django template tags that aren't in code blocks are currently mis-interpreted as GitBook template tags, leading to wrong rendering, e.g. of

## Make our comments visible
Go to the `blog/templates/blog/post_detail.html` file and add the following lines before the `{% endblock %}` tag:
at https://tutorial-extensions.djangogirls.org/en/homework_create_more_models#make-our-comments-visible:

image

This change (wrapping those tags in {% raw %} ... {% endraw %}) should hopefully fix that, but I didn't try it locally, so I couldn't check how the result looks.

Thanks to @macmurdo for pointing out this problem on Gitter.

@das-g das-g requested a review from magul January 27, 2021 13:28
Copy link
Member

@magul magul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that it will work, but really don't know how to test it locally (and if it will be pushed to new GitBook).

I recall discussion in DjangoGirls/djangogirls#537 about migration to new GitBook - it would be great if @amakarudze could share how to build these assets locally and how to ensure they were deployed successfully?

@das-g das-g requested a review from amakarudze January 27, 2021 20:53
@das-g
Copy link
Member Author

das-g commented Feb 21, 2022

As there hasn't been any feedback, shall we just merge this and see how the result looks?

@das-g das-g merged commit c06c15c into DjangoGirls:master Feb 22, 2022
@das-g
Copy link
Member Author

das-g commented Feb 22, 2022

As there hasn't been any replies and the issue continued to confuse readers of the tutorial extensions, I've merged this now, hoping it fixes the problem properly. If it makes things worse, we can always revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants