Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce __lte=now() instead of isnull=False #259

Merged
merged 2 commits into from
Feb 13, 2015

Conversation

aniav
Copy link
Member

@aniav aniav commented Feb 12, 2015

In #249 there is a suggestion to move from isnull=False to __lte=now(). I have done this and slightly changed the text in English and Polish version. I need someone to look at the Ukrainian version and tell me what change should I make to the one sentence that has been changed.

Previously there was:

You can also get a list of all published posts. We do it by filtering all the posts that have published_date:

Now we have:

You can also get a list of all published posts. We do it by filtering all the posts that have published_date set in the past:

In Ukrainian the sentence is currently:

Також можна отримати список усіх опублікованих постів. Зробимо це відфільтрувавши усі пости, що мають published_date:

@aniav
Copy link
Member Author

aniav commented Feb 12, 2015

@chupakabra can you help me with that? Should be an easy one ;)

aniav added a commit that referenced this pull request Feb 13, 2015
Introduce __lte=now() instead of isnull=False
@aniav aniav merged commit 789210f into DjangoGirls:master Feb 13, 2015
@aniav
Copy link
Member Author

aniav commented Feb 13, 2015

Ukrainian version updated thanks to @ruslansavenok. Woohoo! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant