Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes for HTML chapter #27

Merged
merged 2 commits into from
Jul 16, 2014
Merged

Suggested changes for HTML chapter #27

merged 2 commits into from
Jul 16, 2014

Conversation

evildmp
Copy link
Contributor

@evildmp evildmp commented Jul 15, 2014

I hope this helps!

Some points:

  • I have changed website to webpage in a few places, because here we are clearly talking about just one page
  • I have changed deprecated markup such as <b> to semantic markup such as <strong>, and non-semantic language such as "bigger" to "more important"
  • h1 are headings, not headers (different things!)
  • I removed the <small> tag - it's actually for legal information (i.e. the "small print") - sorry that it makes the page inconsistent with the image
  • I introduced the concept of 'elements' so we are not just talking about tags

I do hope that these changes don't mean extra work changing things later on.

@evildmp evildmp mentioned this pull request Jul 15, 2014
22 tasks
@olasitarska
Copy link
Member

It's really great, thank you for your help! 👍

olasitarska added a commit that referenced this pull request Jul 16, 2014
Suggested changes for HTML chapter
@olasitarska olasitarska merged commit 3dea4f3 into DjangoGirls:master Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants