Replace libdparse with DMD in UnusedParameterCheck #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check warns for unused function parameters, with the following exceptions:
This visitor inherits a common chain of visitors also used for UnusedVariableCheck (UnusedIdentifierCheck and UnusedStorageCheck. I've decided to move this check to DMD without moving it's parent classes, since most of the base class functionality is needed for the unused var check.
My approach for this visitor is:
I've also added extra tests for override functions and ref / out / pointer params.
Also, the check is not 100% correct. Given the following example:
The libdparse visitor fails to warn for unused param 'a' in 'testNested'. I've kept the same behavior in DMD version.