Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Bayan #6

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

CSS Bayan #6

wants to merge 45 commits into from

Conversation

Dmitriy-Frostoff
Copy link
Owner

@Dmitriy-Frostoff Dmitriy-Frostoff commented Mar 11, 2023

  1. Task: link
  2. Screenshot:
    image
  3. Deploy: link
  4. Done 13.03.2023 / deadline 13.03.2023
  5. Score: 135 / 140

Your score - 135 points

Feedback on the points of the TR:


Items not completed/not counted:

  • 1) All blocks/parts of the accordion are in base flow of the dom elements. All elements are not positioned with top, left, right, bottom. float is not used. The value of position is only static. Note: usage of display: none is ALLOWED

Feedback: position relative and position absolute was used only for meme displaying on hover and click on label;

Completed items:

  • 1) Public repository with name "cssBayan" created

  • 2) Branch gh-pages created

  • 3) The "cssBayan" folder has been created in the gh-pages branch. Deploy is available via link, link example: https://${YOUR_GITHUB_NAME}.github.io/cssBayan/cssBayan/index.html

  • 4) There are at least 5 commits in the gh-pages branch with the history of the project development

  • 5) The commits are called accordingly to the guideline (https://docs.rs.school/#/git-convention), each commit contains a time-stamp. Time-stamp can be at any language. Accordingly to your time-stamp should be clear, when this commit was done: day of the week, month, day, year, time with seconds (the order can vary) e.g. Commit message example: feat: add basic page layout (Mon, Sep 13, 2021 10:25:24 PM)

  • 6) Pull Request from gh-pages branch to main branch is open. Pull Request name is equal to the task name. Description of the Pull Request was done accordingly to the guideline (https://docs.rs.school/#/pull-request-review-process?id=%D0%A2%D1%80%D0%B5%D0%B1%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D1%8F-%D0%BA-pull-request-pr). The link to this Pull Request was submitted to the cross check form. This Pull Request was NOT merged

  • 7) The accordion component is centered on the screen, with equal indents on the left and right

  • 8) Icons, meme texts and meme images are exist

  • 9) Placement of the meme, icons and meme text are the same as in provided example gif images

  • 10) Smooth change (transition) of the meme images and icons is done

  • 11) Responsive design with three breakpoints for mobile, tablet, and desktop exist. Accordion is displayed correctly at mobile 320x568, tablet 820x1180, desktop 1920x1080. (Note: breakpoints don't have to be 320x568, 820x1180, 1920x1080)

  • 12) All visual effects when the cursor is hovering over the memes, when the mouse is down on a meme, and when a meme is selected are implemented

  • 13) The entire row (text, icon, and meme image) clickable

  • 14) Cursor over the memes (hover) effect only exists for devices that can support hover. This means that the touch device (phone, tablet) doesn't have hover effects, and desktop does have hover effects

  • 15) The cursor when it is hovering over the rows of the accordion is changing

  • 16) Only flexible dimensions are used (rem, em, %, vh, vw, fr and etc.). The accordion is responsive

  • 17) Pseudo-elements are not used (note 1: pseudo-classes are ALLOWED; note 2: pseudo-elements ONLY from FontAwesome are allowed)

  • 18) Initially, the first meme should be expanded

  • 19) Font size is changed at each device (mobile, tablet, desktop)

Dmitriy-Frostoff and others added 13 commits March 11, 2023 18:03
…style and themes, add header, main and footer; Sat Mar 11 21:28:11 RTZ 2023
…ions to the title Sun Mar 12 01:16:34 RTZ 2023
feat: add variables to organize the project structure, …
fix: fix problem with height of the main section Sun Mar 12 01:19:53 …
feat: add animation on hover to the logo bayan Sun Mar 12 01:41:16 RT…
feat: add animation pulsation to all links Sun Mar 12 01:50:33 RTZ 2023
…te of the bayan section; fix: fix problems all over the project with height in vv, with footer elements; feat: add awesome fonts for icons usage Sun Mar 12 05:40:24 RTZ 2023
feat: divide content field, …
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 02:42 — with GitHub Pages Inactive
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 04:11 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 12, 2023 23:07
…ties; add first template of meme; add animations to bayan elements and content; fix: fix problems all over the project Sun Mar 12 23:07:31 RTZ 2023
feat: add basic logic of hovering, opening accordion using CSS proper…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 20:09 — with GitHub Pages Inactive
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 20:12 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 13, 2023 00:35
…der of the memes in folder Mon Mar 13 00:35:19 RTZ 2023
feat: add memes content to the index.html with description; change or…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 21:37 — with GitHub Pages Inactive
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 22:00 — with GitHub Pages Inactive
…r on hover the bayan content, now its for desktop only Mon Mar 13 01:11:17 RTZ 2023
fix: fix problems all over the project; feat: change adoptive behavio…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 22:12 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 13, 2023 02:03
…ence of bayan-content using position properties and animations Mon Mar 13 02:03:50 RTZ 2023
fix: fix problems all over the project; feat: implement smooth appear…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 23:05 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 13, 2023 02:39
…ures and implemented things Mon Mar 13 02:39:06 RTZ 2023
docs: update the project documentation with basic description of feat…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 12, 2023 23:40 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 5 commits March 13, 2023 16:44
…t doesn't have cursor pointer now Mon Mar 13 16:44:30 RTZ 2023
…nts. Now only one meme can be choosen simultaneously. It's implemented by using input type = radio Mon Mar 13 16:49:53 RTZ 2023
…ed; fix behavior of the plus icon on container hover, now it behave as required Mon Mar 13 18:20:28 RTZ 2023
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 13, 2023 16:07 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 13, 2023 19:21
feat: change input classname from ...checkbox to approapriate ...radi…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 13, 2023 16:23 — with GitHub Pages Inactive
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 13, 2023 18:53 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 13, 2023 22:10
fix: fix problem with h1 welcome title centering at tablet resolution…
@Dmitriy-Frostoff Dmitriy-Frostoff temporarily deployed to github-pages March 13, 2023 19:12 — with GitHub Pages Inactive
Dmitriy-Frostoff and others added 2 commits March 14, 2023 17:58
…in top for it; fix: change low case letter in one meme label to upper case Tue Mar 14 17:58:43 RTZ 2023
feat: change font size of meme label on mobile devices, add some marg…
Dmitriy-Frostoff and others added 2 commits November 6, 2023 20:45
…; docs: update deploy link (Mon, Nov 06, 2023 08:45:17 PM)
refactor: change cssBayan project structure due to the TR of the task; docs: update deploy link (Mon, Nov 06, 2023 08:45:17 PM)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant