Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line separator between pages #4

Open
B-greg opened this issue Nov 8, 2019 · 3 comments
Open

Line separator between pages #4

B-greg opened this issue Nov 8, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@B-greg
Copy link

B-greg commented Nov 8, 2019

Hi,
Is it possible to add a line separator, or a margin between. each page of the PDF?
For now all page are next to each other, and it's can be confusing when the next page start an end.

@Dmitry-Borodin Dmitry-Borodin added enhancement New feature or request help wanted Extra attention is needed labels Feb 4, 2020
@Dmitry-Borodin
Copy link
Owner

Thank you for contribution, this is very good idea and should be fairly easy to implement.
I will take a look there when I'll have time, I don't know when. Unless somebody else would like to implement it. Contributions are welcome.

@B-greg
Copy link
Author

B-greg commented Mar 26, 2020

I was looking how to do it, but as all the PDF is read as bitmap, it's hard to find where there is a new page. I will try to look again when I got free time.

@Dmitry-Borodin
Copy link
Owner

@B-greg
PDFRegionDecoder.kt:27
PDFRegionDecoder.kt:48 and below

We will have to add another raw bitmap in between pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants