Make isPointInsidePath() more robust by adding jitter to cast ray. Fixes

#1130.
DmitryBaranovskiy · Mar 3, 2021 · 0a52e95 · 0a52e95
1 parent b5fdbdc
commit 0a52e95
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/dev/raphael.core.js b/dev/raphael.core.js
@@ -1555,7 +1555,7 @@ define(["eve"], function(eve) {
     R.isPointInsidePath = function (path, x, y) {
         var bbox = R.pathBBox(path);
         return R.isPointInsideBBox(bbox, x, y) &&
-               interPathHelper(path, [["M", x, y], ["H", bbox.x2 + 10]], 1) % 2 == 1;
+               interPathHelper(path, [["M", x, y], ["l", bbox.width + 10, Math.random()]], 1) % 2 == 1;
     };
     R._removedFactory = function (methodname) {
         return function () {

diff --git a/raphael.js b/raphael.js
@@ -1685,7 +1685,7 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;!(__WEBPACK_AMD_
     R.isPointInsidePath = function (path, x, y) {
         var bbox = R.pathBBox(path);
         return R.isPointInsideBBox(bbox, x, y) &&
-               interPathHelper(path, [["M", x, y], ["H", bbox.x2 + 10]], 1) % 2 == 1;
+               interPathHelper(path, [["M", x, y], ["l", bbox.width + 10, Math.random()]], 1) % 2 == 1;
     };
     R._removedFactory = function (methodname) {
         return function () {

diff --git a/raphael.min.js b/raphael.min.js
diff --git a/raphael.no-deps.js b/raphael.no-deps.js
@@ -1685,7 +1685,7 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;!(__WEBPACK_AMD_
     R.isPointInsidePath = function (path, x, y) {
         var bbox = R.pathBBox(path);
         return R.isPointInsideBBox(bbox, x, y) &&
-               interPathHelper(path, [["M", x, y], ["H", bbox.x2 + 10]], 1) % 2 == 1;
+               interPathHelper(path, [["M", x, y], ["l", bbox.width + 10, Math.random()]], 1) % 2 == 1;
     };
     R._removedFactory = function (methodname) {
         return function () {

diff --git a/raphael.no-deps.min.js b/raphael.no-deps.min.js