Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config: Support different directory structures #137

Open
franzliedke opened this issue May 11, 2023 · 1 comment
Open

Default config: Support different directory structures #137

franzliedke opened this issue May 11, 2023 · 1 comment

Comments

@franzliedke
Copy link

Hi and thanks for the excellent package! 👏🏼

We are currently working on breaking down our Rails monolith with some tools from the packs ecosystem. This led us to moving all our GraphQL code to a folder packages/web_graphql.

This clashes with the default Include and Exclude rules in this package, which often hardcode a graphql directory. Example:

Include:
- "**/graphql/**/*"

If this was the only rule, then I wouldn't worry about it so much, and we did override it in our Rubocop config for now. But since there are several other, more specific rules also using similar constructs, I'm worried about quietly and unintentionally skipping a lot of valuable cops.

Would you be open to changing this to *graphql* to make it work with any directory containing the term "graphql"?

@DmitryTsepelev
Copy link
Owner

Hey @franzliedke, thanks for the warm words 🙂

*graphql* sounds reasonable, but I wonder if we could make it configurable in a single place (cause someone might want something else like gql). For instance, rules will have Include: "**/<gql_folder>/**/*", while somewhere else we'd have something like gql_folder: graphql or gql_folder: web_graphql . Not sure if it's possible though 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants