Allow_nil: true not working

[majksner]

Hi @DmitryTsepelev,

Thanks for the gem! It seems allow_nil: true not working, when I try to save model with json attributes set to nil it raises

raise StoreModel::Types::CastError,
                "failed casting #{value.inspect}, only String or Array instances are allowed"

or

raise StoreModel::Types::CastError,
                "failed casting #{value.inspect}, only String, " \
                "Hash or #{@model_klass.name} instances are allowed"

If I add

when nil then value

in both array_type.rb and json_type.rb everything works fine.

[DmitryTsepelev]

🤦‍♂ I guess I know where it comes from - investigating

[majksner]

[27] pry(main)> machine = Machine.new(project_id: 1, configuration: nil)
=> #<Machine:0x00007fdeae95dfc8
 id: nil,
 project_id: 1,
 configuration: nil>
[28] pry(main)> machine.save!
   (0.3ms)  BEGIN
   (0.3ms)  ROLLBACK
StoreModel::Types::CastError: failed casting nil, only String, Hash or MachineConfig instances are allowed
from /Users/test/.rvm/gems/ruby-2.6.3/gems/store_model-0.3.0/lib/store_model/types/json_type.rb:22:in `cast_value'

[DmitryTsepelev]

@majksner Thank you for catching this! Just released 0.3.1 with the fix according to your suggestion

[majksner]

You're welcome, I could still see one problem and that is we don't check if allow_nil: true is set anywhere in the code.

[DmitryTsepelev]

In this case we use a regular ActiveRecord validation, and allow_nil is shipped out of the box

[majksner]

👍🏻 Thanks for the such a quick fix!