feat: Use type safe metrics struct #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 80.50% 81.24% +0.73%
==========================================
Files 91 93 +2
Lines 3273 3449 +176
==========================================
+ Hits 2635 2802 +167
- Misses 463 472 +9
Partials 175 175
Continue to review full report at Codecov.
|
GGXXLL
previously approved these changes
Aug 30, 2021
GGXXLL
previously approved these changes
Aug 30, 2021
Reasno
added a commit
that referenced
this pull request
Aug 31, 2021
* feat: Use type safe metrics struct * doc: add comment * Update doc.go * refactor: use point receivers * test: fix tests * test: fix tests
Reasno
added a commit
that referenced
this pull request
Aug 31, 2021
#187) * fix(container): shutdown the modules in the reversed order of registration * fix(container): shutdown the modules in the reversed order of registration * feat(clihttp): limit max length a client can read from body (#186) * feat: limit the length when read body * fix: WithResponseLogThreshold error and add test case * refactor(container): remove ifilter dependency. (#183) * refactor: change how DI and container works * docs: clarify words * test: test the cleanup function is executed * test: cover current behavior * refactor: change how DI and container works * docs: clarify words * test: test the cleanup function is executed * test: cover current behavior Co-authored-by: Trock <35254251+GGXXLL@users.noreply.github.com> * feat: make metrics struct type safe (#185) * feat: Use type safe metrics struct * doc: add comment * Update doc.go * refactor: use point receivers * test: fix tests * test: fix tests * fix(container): test Co-authored-by: Trock <35254251+GGXXLL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make predefinedned metrics a dedicated type rather than an interface. This gives user more type safety. See https://medium.com/@sameer_74231/go-experience-report-for-generics-google-metrics-api-b019d597aaa4