Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WithoutCancel #200

Merged
merged 6 commits into from Sep 27, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions ctxmeta/without_cancel.go
Expand Up @@ -10,11 +10,11 @@ type asyncContext struct {
}

func (a asyncContext) Deadline() (deadline time.Time, ok bool) {
return time.Time{}, false
return
GGXXLL marked this conversation as resolved.
Show resolved Hide resolved
}

func (a asyncContext) Done() <-chan struct{} {
return make(chan struct{})
return nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of this change?

}

func (a asyncContext) Err() error {
Expand All @@ -28,11 +28,16 @@ func (a asyncContext) Value(key interface{}) interface{} {
// WithoutCancel creates a new context from an existing context and inherits all
// values from the existing context. However if the existing context is
// cancelled, timeouts or passes deadline, the returning context will not be
// affected. This is useful in an async HTTP handler. When the http response is sent, the request context will be cancelled. If you still want to access the value from request context (eg. tracing), you can use:
// affected. This is useful in an async HTTP handler. When the http response is sent,
// the request context will be cancelled. If you still want to access the value from request context (eg. tracing),
// you can use:
// func(request *http.Request, responseWriter http.ResponseWriter) {
// go DoSomeSlowDatabaseOperation(WithoutCancel(request.Context()))
// responseWriter.Write([]byte("ok"))
// }
func WithoutCancel(requestScopeContext context.Context) (valueOnlyContext context.Context) {
if requestScopeContext == nil {
panic("cannot create context from nil parent")
}
return asyncContext{requestScopeContext}
}
7 changes: 7 additions & 0 deletions ctxmeta/without_cancel_test.go
Expand Up @@ -24,3 +24,10 @@ func TestWithoutCancel(t *testing.T) {
assert.Nil(t, WithoutCancel(ctx).Err())
assert.Equal(t, "value", WithoutCancel(ctx).Value(key))
}

func TestWithoutCancel_Nil(t *testing.T) {
defer func() {
assert.Equal(t, recover(), "cannot create context from nil parent")
}()
WithoutCancel(nil)
}