Remove deprecated pre-TGM Contentful lib functions #1022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
lib/contentful
functions no longer used in production:fetchBroadcast
,fetchCampaign
,fetchMessageForCampaignId
, andrenderMessageForPhoenixCampaign
parseDefaultAndOverrideContentfulCampaignsResponse
asparseDefaultAndOverrideCampaignsResponse
, and adds to exports for test coveragefetchDefaultAndOverrideContentfulCampaignsForCampaignId
asfetchDefaultAndOverrideCampaignsForCampaignId
, adds test coverage for the middleware that calls it (lib/middleware/campaigns-single/contentful-campaigns
)How should this be reviewed?
Verify
GET /campaigns
andGET /campaigns/:id
responses return expected data.Any background context you want to provide?
I'd like to deprecate the use of the Contentful campaign with
campaignId
set todefault
for defining default fields, and instead hardcode the default values to use if an optional field doesn't exist on the Campaign. Didn't make that change in this branch to help keep it reviewable.I'll be testing on staging by setting the Phoenix URL config variable to point to Ashes, putting Support Ashes and Phoenix URLs via config #1019 on hold.
Relevant tickets
Cleanup work to prep for new Gambini types and fields in #1021
Checklist