Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf Rewrite And Better DSL #53

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Perf Rewrite And Better DSL #53

wants to merge 7 commits into from

Conversation

bcardarella
Copy link
Member

@bcardarella bcardarella commented Jul 21, 2016 •
edited by nicomihalich

  • compile time fixture parsing
  • module attribute @fixture loading
  • new fixture dsl
  • fixture grouping
  • single DAG creation
  • proper association graph
  • serialization api
  • reload api
  • move primary key generation into compile time
  • move inheritance into compile time
  • possibly move association into compile time (will require DAG reconsideration)
  • transform row values transform :owner, %{foo: "bar"}
  • force no insert insert: false
  • fixtures now Elixir modules
  • contexts, fallback to :default
  • move serializer function into Fixtures module
  • serialize opts
  • update README
  • ensure options for fixtures don't clash, first wins
  • multiple groups per fixture
  • macro based functions

Closes #37
Closes #14
Closes #47

@bcardarella bcardarella added this to the 0.1.0 milestone Jul 21, 2016
@bcardarella bcardarella force-pushed the bc-new-fixture-api branch 7 times, most recently from 186cf32 to 3ff77fe Compare July 25, 2016 19:54
@bcardarella bcardarella force-pushed the bc-new-fixture-api branch 5 times, most recently from cf2b5a4 to 6268bc5 Compare August 2, 2016 21:12
@bcardarella bcardarella force-pushed the bc-new-fixture-api branch 2 times, most recently from 28f522e to c71840b Compare August 12, 2016 15:11
@bcardarella bcardarella mentioned this pull request Aug 13, 2016
Closed
@williamweckl
Copy link

@bcardarella I'm new to both phoenix and elixir and miss rails like fixtures.
What is needed to merge this on master?
Anyway I'll use your branch for now.

@bcardarella
Copy link
Member Author

@williamweckl I was considering cutting a release. The remaining open items are perf related and don't affect API. I'll spend some time today updating the README and documentation.

@bcardarella bcardarella force-pushed the bc-new-fixture-api branch 3 times, most recently from d7ef89f to 017b0da Compare October 9, 2016 21:42
@bcardarella
Rewrite
c09a5e7 
* Moved fixture parsing and some of the fixture data setup to
  compile time instead of run time

* Make sure of ExUnit module attributes to runing of the fixtures

* Match feature parity with previous version

* Generators

* Transforms

* Insert API

* Reloader

* Macro-based API
@bcardarella
Updated fixture API
060f3a4 
* Pure Elixir modules for fixtures
* Drop virtual columns in favor of elixir code
* Drop generators in favor of elixir code
* Drop enums in favor of elixir code
* Support serializer and repo contexts via `context` macro
@bcardarella
Ensure contexts
d8f71fa
@bcardarella
Update reloader to ensure corect repo is found
cbdbac1
@bcardarella
Update serializer retrieval
4504ab9
@bcardarella bcardarella mentioned this pull request Mar 6, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

New API Allow repo to be inherited from a module variable Ecto 2.0 compatibility
3 participants
@bcardarella @williamweckl @alexgaribay