Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "New Module Imports" #278

Merged
merged 4 commits into from Jul 28, 2017
Merged

Use "New Module Imports" #278

merged 4 commits into from Jul 28, 2017

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jul 28, 2017

@cibernox
Copy link
Contributor

It looks good but there is still imports using the old shims we have to fix. Does the codemod support those?

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jul 28, 2017

It looks good but there is still imports using the old shims we have to fix.

looks like I missed those 🙈

Does the codemod support those?

no, but the no-old-shims ESLint rule does

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jul 28, 2017

It looks good but there is still imports using the old shims we have to fix

done :)

@cibernox cibernox merged commit ad5d089 into DockYard:master Jul 28, 2017
@cibernox
Copy link
Contributor

New shims all-the-things!

@Turbo87 Turbo87 deleted the new-module-imports branch July 28, 2017 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cibernox cibernox cibernox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Turbo87 @cibernox