Internal: Update IntersectionObserverAdmin + simplify #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
changed the title
snewcomer
commented
Apr 20, 2019
| return this.ioAdmin.observe(...args); | ||
| add(element, observerOptions, enterCallback, exitCallback) { | ||
| if (enterCallback) { | ||
| this.instance.addEnterCallback(element, enterCallback); |
There was a problem hiding this comment.
We could add an API to this class such as addEnterCallback with an element && function. The user would need to so something like inViewport.addEnterCallback(element, callback) with the service. When the element intersects or exists, we (internal library) dispatches an event to call that callback. This would allow us to be tied only as a mixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the ability register callbacks with intersection observer admin. Eventually will try to return outan instance and allow end user to add the callback function.
snewcomer/intersection-observer-admin#5