rework trace_started? to use ETS table instead of GenServer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheFirstAvenger
force-pushed
the
mb-trace-started-rework
branch
2 times, most recently
from
2713a8c
to
dfe91d7
Compare
TheFirstAvenger
force-pushed
the
mb-liveview-0-18
branch
2 times, most recently
from
2277251
to
10bad9e
Compare
TheFirstAvenger
force-pushed
the
mb-trace-started-rework
branch
from
dfe91d7
to
c19d3b6
Compare
TheFirstAvenger
force-pushed
the
mb-trace-started-rework
branch
from
c19d3b6
to
b0ac06d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the current
trace_started?function to not bottleneck on the Trace GenServer. Should fix issue noted here.Note this is branched off the existing LiveView upgrade branch.