Change the naming of the response exceptions pool into factory

DoclerLabs · Sep 11, 2020 · 0e23541 · 0e23541
1 parent 1689b7a
commit 0e23541
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/Exception/ResponseExceptionsPool.php → src/Exception/ResponseExceptionFactory.php b/src/Exception/ResponseExceptionsPool.php → src/Exception/ResponseExceptionFactory.php
@@ -2,7 +2,7 @@
 
 namespace DoclerLabs\ApiClientBase\Exception;
 
-class ResponseExceptionsPool
+class ResponseExceptionFactory
 {
     /** @var string[] */
     private $responseExceptions;
@@ -18,7 +18,7 @@ public function __construct()
         ];
     }
 
-    public function getException(int $statusCode, string $responseBody): UnexpectedResponseException
+    public function create(int $statusCode, string $responseBody): UnexpectedResponseException
     {
         if (isset($this->responseExceptions[$statusCode])) {
             return new $this->responseExceptions[$statusCode]($responseBody);

diff --git a/src/Response/Handler/ResponseHandler.php b/src/Response/Handler/ResponseHandler.php
@@ -6,7 +6,7 @@
 use DoclerLabs\ApiClientBase\Exception\ForbiddenResponseException;
 use DoclerLabs\ApiClientBase\Exception\NotFoundResponseException;
 use DoclerLabs\ApiClientBase\Exception\PaymentRequiredResponseException;
-use DoclerLabs\ApiClientBase\Exception\ResponseExceptionsPool;
+use DoclerLabs\ApiClientBase\Exception\ResponseExceptionFactory;
 use DoclerLabs\ApiClientBase\Exception\UnauthorizedResponseException;
 use DoclerLabs\ApiClientBase\Exception\UnexpectedResponseException;
 use DoclerLabs\ApiClientBase\Json\Json;
@@ -19,12 +19,12 @@ class ResponseHandler implements ResponseHandlerInterface
 {
     const JSON_OPTIONS = JSON_PRESERVE_ZERO_FRACTION + JSON_BIGINT_AS_STRING;
 
-    /** @var ResponseExceptionsPool */
-    private $responseExceptionsPool;
+    /** @var ResponseExceptionFactory */
+    private $responseExceptionsFactory;
 
     public function __construct()
     {
-        $this->responseExceptionsPool = new ResponseExceptionsPool();
+        $this->responseExceptionsFactory = new ResponseExceptionFactory();
     }
 
     /**
@@ -62,7 +62,7 @@ public function handle(ResponseInterface $response): Response
             return new Response($statusCode, $decodedPayload, $headers);
         }
 
-        throw $this->responseExceptionsPool->getException($statusCode, $responseBody);
+        throw $this->responseExceptionsFactory->create($statusCode, $responseBody);
     }
 
     private function isResponseBodyEmpty(StreamInterface $responseBody = null): bool

diff --git a/.../Exception/ResponseExceptionsPoolTest.php → ...ception/ResponseExceptionsFactoryTest.php b/.../Exception/ResponseExceptionsPoolTest.php → ...ception/ResponseExceptionsFactoryTest.php
@@ -6,28 +6,28 @@
 use DoclerLabs\ApiClientBase\Exception\ForbiddenResponseException;
 use DoclerLabs\ApiClientBase\Exception\NotFoundResponseException;
 use DoclerLabs\ApiClientBase\Exception\PaymentRequiredResponseException;
-use DoclerLabs\ApiClientBase\Exception\ResponseExceptionsPool;
+use DoclerLabs\ApiClientBase\Exception\ResponseExceptionFactory;
 use DoclerLabs\ApiClientBase\Exception\UnauthorizedResponseException;
 use DoclerLabs\ApiClientBase\Exception\UnexpectedResponseException;
 use PHPUnit\Framework\TestCase;
 
 /**
- * @coversDefaultClass \DoclerLabs\ApiClientBase\Exception\ResponseExceptionsPool
+ * @coversDefaultClass \DoclerLabs\ApiClientBase\Exception\ResponseExceptionFactory
  */
-class ResponseExceptionsPoolTest extends TestCase
+class ResponseExceptionsFactoryTest extends TestCase
 {
     /**
      * @dataProvider exceptionsDataProvider
      * @covers ::__construct
-     * @covers ::getException
+     * @covers ::create
      */
-    public function testGetException(int $statusCode, string $body, string $expectedExceptionClass)
+    public function testCreate(int $statusCode, string $body, string $expectedExceptionClass)
     {
-        $sut = new ResponseExceptionsPool();
+        $sut = new ResponseExceptionFactory();
 
         $this->expectException($expectedExceptionClass);
 
-        throw $sut->getException($statusCode, $body);
+        throw $sut->create($statusCode, $body);
     }
 
     public function exceptionsDataProvider(): array