Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creation webcookeis for EAuthTokenPlatformType.WebBrowser #37

Merged
merged 4 commits into from Jan 18, 2024

Conversation

Sadzurami
Copy link
Contributor

Valve (again) change web authorization. Now we have different cookies for all subdomains.

Eg. cookies from steamcommunity.com now we can't use for store.steampowered.com, etc.
New access token audience:

store.steampowered.com

"aud": [
    "web:store"
]

steamcommunity.com

"aud": [
    "web:community"
]

Only fair for creation cookies with EAuthTokenPlatformType.WebBrowser.
EAuthTokenPlatformType.SteamClient and EAuthTokenPlatformType.MobileApp still creates cookies with common audience:

"aud": [
    "web",
    "mobile"
]

So, will be better to return full cookies strings with Domain attribute.
Will require some changes on client side, but popular packages that maintain cookies (CookieJar) automatically can use full and short variants.

@DoctorMcKay
Copy link
Owner

Dammit, Valve.

Are you ready for this to be merged?

@Sadzurami
Copy link
Contributor Author

Dammit, Valve.

Are you ready for this to be merged?

ready

@DoctorMcKay DoctorMcKay merged commit 005d05f into DoctorMcKay:master Jan 18, 2024
9 checks passed
@DoctorMcKay
Copy link
Owner

getWebCookies is actually returning an array of arrays, will fix this.

@DoctorMcKay
Copy link
Owner

Technically, the access_token returned in PollAuthSessionResponse is still valid for "web", but Valve has already removed that token once before so probably best not to rely on it.

@Sadzurami
Copy link
Contributor Author

Sadzurami commented Jan 18, 2024

getWebCookies is actually returning an array of arrays, will fix this.

Sorry for that and thanks for quick fix

@Sadzurami
Copy link
Contributor Author

Sadzurami commented Jan 18, 2024

in 1.7.2 release message there is typo
(with ; Domain=steamcommunity.com appended in the cookie string)

may be misunderstanding, better change to smth like
(with ; Domain=<some-steam-domain> appended in the cookie string)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants