Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setTimeout of undefined exception in connection logic #322

Merged
merged 2 commits into from Jul 28, 2020

Conversation

itsjfx
Copy link
Contributor

@itsjfx itsjfx commented Jul 17, 2020

I'm still trying to trace what span of events lead to the crash occurring, however this little check fix will prevent a program from throwing an exception. This makes the ChannelEncryptRequest logic only continue if a _connection and stream/socket exists for the login process.

Not a solution to the underlying issue which causes this event of course, but like I said it will stop the exception from occurring.

Solves: #274

@DoctorMcKay
Copy link
Owner

Not the most elegant solution, but it should work...

@DoctorMcKay DoctorMcKay merged commit 11841e8 into DoctorMcKay:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants