Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable primaryGroup profile setting #287

Closed
wants to merge 16 commits into from

Conversation

3urobeat
Copy link
Contributor

@3urobeat 3urobeat commented Jun 3, 2022

Hey!
The primaryGroup setting in the editProfile() function does seem to work again so I decided to open a PR that enables the code block again.

I've tested the function with a limited and an unlimited account. The limited acc has E-Mail steam guard, the unlimited acc is secured with mobile steam guard.

I called the function like this from the webSession event to make sure cookies were set:

const SteamID = require("steamid")

community.editProfile({ //community was set previously as a new SteamCommunity object
    primaryGroup: new SteamID("my_groupID64")
}, (err) => {
    if (err) console.log(err);
})

 

This successfully updated my primaryGroup setting.
I also tested the other two disabled settings (background & featuredBadge) but was unable to get them to work as well :(

@3urobeat
Copy link
Contributor Author

3urobeat commented Jun 3, 2022

Oh and while you are here - one question:
Is there something holding you back from updating the dependencies? async, image-size, node-bignumber, steam-totp, steamid and xml2js are all out of date (and async seems to have a security vulnerability).

@Revadike
Copy link
Contributor

Revadike commented Jun 3, 2022

Oh and while you are here - one question: Is there something holding you back from updating the dependencies? async, image-size, node-bignumber, steam-totp, steamid and xml2js are all out of date (and async seems to have a security vulnerability).

he's busy with a major rewrite (v4), which is taking a long time...

@3urobeat
Copy link
Contributor Author

Closing this PR because I added more commits to my master branch. Transferred to #307.

@3urobeat 3urobeat closed this May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants