-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.parse not working as expected (unit tests fail) #67
Comments
Me and @mbrendler just figured out that the bug was introduced in c0e27bf, we are taking a deeper look at this right now. Ping here, if you have any thoughts. |
#69 fixes this for multiline comments that look like: /*
* @name Foo
*/ …but it still fails for a syntax like mentioned in the README: //
// @name Foo
// |
- Change the test data to use multi line comments It seems that the implementation only works with this data - Fix parsing (index was one off) - Remove leading * from first line in markup blocks All tests are passing now
- Change the test data to use multi line comments It seems that the implementation only works with this data - Fix parsing (index was one off) - Remove leading * from first line in markup blocks All tests are passing now - Ignore npm-debug.log
Do you have plans how to solve this? |
@ahx Yep. I had a fix in the works about 2 weeks ago. I'll try and push that up this weekend. Definitely ping me again if you don't see any activity by Monday morning |
Ping @darcyclarke ❤️ 🌷 🎆 🗼 |
ping @darcyclarke 😃 |
This project has become pretty stale. – Do you think #68 should be done before trying to solve this within the current implementation? |
The unit tests added in #66 are failing.
The text was updated successfully, but these errors were encountered: