Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.parse not working as expected (unit tests fail) #67

Closed
ahx opened this issue May 19, 2015 · 7 comments
Closed

.parse not working as expected (unit tests fail) #67

ahx opened this issue May 19, 2015 · 7 comments
Labels

Comments

@ahx
Copy link
Contributor

ahx commented May 19, 2015

The unit tests added in #66 are failing.

@ahx
Copy link
Contributor Author

ahx commented Jun 4, 2015

Me and @mbrendler just figured out that the bug was introduced in c0e27bf, we are taking a deeper look at this right now. Ping here, if you have any thoughts.

@ahx
Copy link
Contributor Author

ahx commented Jun 4, 2015

#69 fixes this for multiline comments that look like:

/*
* @name Foo
*/

…but it still fails for a syntax like mentioned in the README:

//
// @name Foo
//

ahx added a commit to ahx/DSS that referenced this issue Jun 18, 2015
- Change the test data to use multi line comments
  It seems that the implementation only works with this data
- Fix parsing (index was one off)
- Remove leading * from first line in markup blocks

All tests are passing now
ahx added a commit to ahx/DSS that referenced this issue Jun 18, 2015
- Change the test data to use multi line comments
  It seems that the implementation only works with this data
- Fix parsing (index was one off)
- Remove leading * from first line in markup blocks

All tests are passing now

- Ignore npm-debug.log
@ahx
Copy link
Contributor Author

ahx commented Jun 19, 2015

Do you have plans how to solve this?

@darcyclarke
Copy link
Member

@ahx Yep. I had a fix in the works about 2 weeks ago. I'll try and push that up this weekend. Definitely ping me again if you don't see any activity by Monday morning

@ahx
Copy link
Contributor Author

ahx commented Jun 23, 2015

Ping @darcyclarke ❤️ 🌷 🎆 🗼

@ygd
Copy link

ygd commented Jul 7, 2015

ping @darcyclarke 😃

@ahx
Copy link
Contributor Author

ahx commented Oct 29, 2015

This project has become pretty stale. – Do you think #68 should be done before trying to solve this within the current implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants