Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default template to something lighter #13

Closed
MoOx opened this issue May 13, 2013 · 5 comments
Closed

Update default template to something lighter #13

MoOx opened this issue May 13, 2013 · 5 comments

Comments

@MoOx
Copy link
Contributor

MoOx commented May 13, 2013

What do you think about having a lighter template that use BEM approch to scope styles correctly ?

Avoid reset, & default styles (with tag) and add a dss-Styleguide prefix on all className of items ?

Look what my template look like right now:

screen shot 2013-05-13 at 3 30 07 pm
screen shot 2013-05-13 at 3 30 24 pm

This seems to bloat the code, but it can avoid having conflict with default styles of the styleguide default styles.
What do you think ?

@kud
Copy link

kud commented Nov 6, 2013

👍

@kud
Copy link

kud commented Nov 6, 2013

even :shipit:

@MoOx
Copy link
Contributor Author

MoOx commented Nov 6, 2013

I can make a PR if @darcyclarke is interested ;)

@kud
Copy link

kud commented Nov 6, 2013

I am, ain't enough?

@darcyclarke
Copy link
Member

Hmm, I think I was trying to avoid this because I eventually wanted to properly scope each example using iframes. @MoOx could you look into that first. If not, I'll look into it asap (obviously have a backlog of issues here now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants