-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to pass css file to the default template #15
Comments
I think the thought here is that if you are using custom css, you will probably need custom markup. |
How do you want to have a living styleguide, without styles themselves ?! |
I see what you're saying now. I was misunderstanding. |
Please, namespace your own css @VinSpee in order not to override the css styleguide itself. ;) Do something like |
@MoOx you are correct. "Sandboxing" the examples, with a reference to your generated stylesheet, seems to be the best way forward. The best way to sandbox, I can think of, is to use To do this we'll need to:
If you want to take a stab at this. That would be awesome. |
Using BEM to scope everything seems a better idea for me. iframe seems overkill to me. |
I'm of the mind that you should not really need any style guide-specific CSS - you should be using the very styles you're outlining. On Wed, Nov 6, 2013 at 3:48 PM, Maxime Thirouin notifications@github.com
|
I think the separation of concerns is important. Many times you create documentation that lives on it's own in it's own context. If you have your documentation's CSS mixed in with your project's CSS you're eventually going to run into issues of specificity (in my mind). But the library and templates are simple enough for you to change to your specific circumstance. If you want to use your generated CSS file and not some specific styleguide CSS all you have to do is update the template ( I think, eventually, |
Closing due to inactivity. |
It would be great to have a option to pass a additional css to actually get the styles in the styleguide without having to duplicate default template.
The text was updated successfully, but these errors were encountered: