Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carousel] If you put an image into a carousel-item, the whole carousel's height gets resized to the height of the image. #4280

Closed
lastnoob opened this issue Feb 22, 2017 · 7 comments
Labels

Comments

@lastnoob
Copy link

lastnoob commented Feb 22, 2017

Description

When you add an to the carousel-item it resizes the carousel's height to the image's height. If you edit the image's height it edits the carousel's. I found it impossible to set the height of the carousel, or the carousel-item with css.

Repro Steps

Insert an image into a carousel item.

Or check this Codepen

Screenshots

image
image

@acburst
Copy link
Collaborator

acburst commented Feb 24, 2017

Would you prefer if you could override the height of the carousel with a plugin option?

@fega fega added the bug label Apr 6, 2017
@tomscholz
Copy link
Contributor

Closed due inactivity. Feel free to reopen it, if it's still necessary.

@wvicioso
Copy link

same issue. I'm trying to place multiple images inside a single carousel-item and the whole carousel keeps resizing

@helderfalcao
Copy link

Someone found the solution?

@lastnoob
Copy link
Author

just give the carousel a fixed height with !important, seems like the easiest solution

@helderfalcao
Copy link

Tks @lastnoob ! I will try it

@phoebebright
Copy link

I am putting images of pages in the carousel and want to view them on maximum size for the screen/device so setting a hard height does not work for me. What would be ideal is to have a "fullSize" option that resizes the carousel to fit the image, making it as large as possible given the constraints of the screen, but does not crop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants