Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy methods for major javascript components #4522

Closed
2 of 7 tasks
acburst opened this issue Apr 11, 2017 · 4 comments
Closed
2 of 7 tasks

Destroy methods for major javascript components #4522

acburst opened this issue Apr 11, 2017 · 4 comments
Labels
help-wanted js

Comments

@acburst
Copy link
Collaborator

acburst commented Apr 11, 2017 •
edited by tomscholz

In general, we do not have destroy methods for many of our javascript components which are helpful for more dynamic sites. I'll start a checklist of plugins that could use destroy methods.

  • Collapsible
  • Carousel
  • Dropdown
  • Modal
  • Tabs
  • Parallax
  • Materialbox

Pull Requests welcome!
@acburst acburst added the js label Apr 11, 2017
@fega
Copy link

fega commented Apr 11, 2017

what about the help-wanted label?

@jacobq jacobq mentioned this issue Apr 12, 2017
Closed
@acburst
Copy link
Collaborator Author

acburst commented Apr 14, 2017

Collapsible destroy added in 79cb76e

@fega fega mentioned this issue Apr 14, 2017
Closed
@tomscholz
Copy link
Contributor

See #2428

@tomscholz
Copy link
Contributor

Carousel destroy added in 22c9729

@tomscholz tomscholz mentioned this issue Jul 8, 2017
Closed
@Dogfalo Dogfalo closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@acburst @Dogfalo @fega @tomscholz